(maint) Do not use git for Gemspec files #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the gemspec was using 'git ls-file' to retrieve the file list for the gem, however this is problematic during development as untracked files are not added, which can then cause an incomplete gem tarball to used during the acceptance tests, which cause false negative test results. This commit updates the Gemspec to use the more common Dir[..] method as used in the PDK.
binford2k
approved these changes
Jun 1, 2020
scotje
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the gemspec was using 'git ls-file' to retrieve the file list for
the gem, however this is problematic during development as untracked files are
not added, which can then cause an incomplete gem tarball to used during the
acceptance tests, which cause false negative test results.
This commit updates the Gemspec to use the more common Dir[..] method as used in
the PDK.